Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator tektoncd-operator (0.68.1) #3484

Merged
merged 1 commit into from
Nov 8, 2023
Merged

operator tektoncd-operator (0.68.1) #3484

merged 1 commit into from
Nov 8, 2023

Conversation

jkandasa
Copy link
Contributor

@jkandasa jkandasa commented Oct 31, 2023 •
edited
Loading

Thanks submitting your Operator. Please check below list before you create your Pull Request.

New Submissions

Updates to existing Operators

  • Did you create a ci.yaml file according to the update instructions?
  • Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
  • Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
  • Have you tested an update to your Operator when deployed via OLM?
  • Is your submission signed?

Your submission should not

  • Modify more than one operator
  • Modify an Operator you don't own
  • Rename an operator - please remove and add with a different name instead
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

  1. Description about the managed Application and where to find more information
  2. Features and capabilities of your Operator and how to use it
  3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

  • Human readable name and 1-liner description about your Operator
  • Valid category name1
  • One of the pre-defined capability levels2
  • Links to the maintainer, source code and documentation
  • Example templates for all Custom Resource Definitions intended to be used
  • A quadratic logo

Remember that you can preview your CSV here.

--

1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need

2 For more information see here

@github-actions GitHub Actions
Copy link
Contributor

@sm43,@vdemeester,@nikhil-thomas , please approve as you are original reviewer(s).

  • To add more contributors to ci.yaml follow instruction here.
  • To approve follow instruction here

@github-actions GitHub Actions
Copy link
Contributor

/hold

@sm43,@vdemeester,@nikhil-thomas , Please note that ci.yml was changed.

  • To approve follow instruction here

@github-actions github-actions bot changed the title operator tektoncd-operator (0.68.1) operator [CI] tektoncd-operator (0.68.1) Oct 31, 2023
@github-actions GitHub Actions
Copy link
Contributor

Dear @jkandasa,
Some errors and/or warnings were found while doing the check of your operator (tektoncd-operator/0.68.1) against the entire suite of validators for Operator Framework with Operator-SDK version v1.30.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type Message
⚠️ Value : (tektoncd-operator.v0.68.1) csv.Spec.minKubeVersion is not informed. It is recommended you provide this information. Otherwise, it would mean that your operator project can be distributed and installed in any cluster version available, which is not necessarily the case for all projects.
⚠️ Value tektoncd-operator.v0.68.1: this bundle is using APIs which were deprecated and removed in v1.25. More info: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25. Migrate the API(s) for cronjobs: (["ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.ClusterPermissions[0].Rules[24]"]),horizontalpodautoscalers: (["ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.ClusterPermissions[0].Rules[21]"]),poddisruptionbudgets: (["ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.ClusterPermissions[0].Rules[22]"]),
⚠️ Value tektoncd-operator.v0.68.1: unable to find the resource requests for the container: (tekton-operator-lifecycle). It is recommended to ensure the resource request for CPU and Memory. Be aware that for some clusters configurations it is required to specify requests or limits for those values. Otherwise, the system or quota may reject Pod creation. More info: https://master.sdk.operatorframework.io/docs/best-practices/managing-resources/
⚠️ Value tektoncd-operator.v0.68.1: unable to find the resource requests for the container: (tekton-operator-cluster-operations). It is recommended to ensure the resource request for CPU and Memory. Be aware that for some clusters configurations it is required to specify requests or limits for those values. Otherwise, the system or quota may reject Pod creation. More info: https://master.sdk.operatorframework.io/docs/best-practices/managing-resources/
⚠️ Value tektoncd-operator.v0.68.1: unable to find the resource requests for the container: (tekton-operator-webhook). It is recommended to ensure the resource request for CPU and Memory. Be aware that for some clusters configurations it is required to specify requests or limits for those values. Otherwise, the system or quota may reject Pod creation. More info: https://master.sdk.operatorframework.io/docs/best-practices/managing-resources/
⚠️ Value tektoncd-operator.v0.68.1: CSV contains permissions to create CRD. An Operator shouldn't deploy or manage other operators (such patterns are known as meta or super operators or include CRDs in its Operands). It's the Operator Lifecycle Manager's job to manage the deployment and lifecycle of operators. Please, review the design of your solution and if you should not be using Dependency Resolution from OLM instead. More info: https://sdk.operatorframework.io/docs/best-practices/common-recommendation/

@jkandasa
Copy link
Contributor Author

jkandasa commented Nov 1, 2023

/retest

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023

/hold

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023

/hold cancel

@vdemeester
Copy link

/approve

@vdemeester
Copy link

/hold cancel
🙏🏼

@framework-automation
Copy link
Collaborator

/merge possible

@framework-automation
Copy link
Collaborator

/merge possible

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Current PR can be merged automatically, but there is missing authorized-changes label. One can find out more info here.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Current PR can be merged automatically, but there is missing authorized-changes label. One can find out more info here.

@adambkaplan adambkaplan mentioned this pull request Nov 2, 2023
Open
@github-actions github-actions bot changed the title operator [CI] tektoncd-operator (0.68.1) operator tektoncd-operator (0.68.1) Nov 8, 2023
vdemeester
vdemeester approved these changes Nov 8, 2023
View reviewed changes
Copy link

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@framework-automation
Copy link
Collaborator

/merge possible

@framework-automation
Copy link
Collaborator

/merge possible

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Current PR can be merged automatically, but there is missing authorized-changes label. One can find out more info here.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Current PR can be merged automatically, but there is missing authorized-changes label. One can find out more info here.

@framework-automation
Copy link
Collaborator

/merge possible

1 similar comment
@framework-automation
Copy link
Collaborator

/merge possible

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Current PR can be merged automatically, but there is missing authorized-changes label. One can find out more info here.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Current PR can be merged automatically, but there is missing authorized-changes label. One can find out more info here.

@vdemeester
Copy link

/hold

@vdemeester
Copy link

/unhold

@framework-automation
Copy link
Collaborator

/merge possible

1 similar comment
@framework-automation
Copy link
Collaborator

/merge possible

@framework-automation framework-automation merged commit ed3e52b into k8s-operatorhub:main Nov 8, 2023
24 checks passed
@jkandasa jkandasa deleted the release_tekton_v0.68.1 branch November 8, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@haripate haripate Awaiting requested review from haripate

@tomasbakk tomasbakk Awaiting requested review from tomasbakk

Assignees

@mporrato mporrato

@Allda Allda

Labels
authorized-changes installation-validated package-validated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jkandasa @vdemeester @framework-automation @mporrato @Allda