bug: fix a bug in multinamespaced cache implementation

This commit fixes a bug that was brought in long ago in kubernetes-sigs#1520. When the object's scope is not deterministic from the RESTMapper it should return an error instead of ignoring it. Signed-off-by: Varsha Prasad Narsing <[email protected]>
k8s-infra-cherrypick-robot · Apr 24, 2023 · 57b0968 · 57b0968
1 parent d9f8c47
commit 57b0968
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pkg/cache/multi_namespace_cache.go b/pkg/cache/multi_namespace_cache.go
@@ -185,7 +185,7 @@ func (c *multiNamespaceCache) WaitForCacheSync(ctx context.Context) bool {
 func (c *multiNamespaceCache) IndexField(ctx context.Context, obj client.Object, field string, extractValue client.IndexerFunc) error {
 	isNamespaced, err := objectutil.IsAPINamespaced(obj, c.Scheme, c.RESTMapper)
 	if err != nil {
-		return nil //nolint:nilerr
+		return err
 	}
 
 	if !isNamespaced {