Skip to content

Commit

Permalink
Merge pull request kubernetes-sigs#8956 from enxebre/doc-MinReadySeconds
Browse files Browse the repository at this point in the history
🌱 Adjust MinReadySeconds docs to reality
  • Loading branch information
k8s-ci-robot authored Jul 4, 2023
2 parents cb5ce4c + 3e7e4f6 commit 4d76266
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 13 deletions.
6 changes: 2 additions & 4 deletions api/v1beta1/machinedeployment_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,8 @@ type MachineDeploymentSpec struct {
// +optional
Strategy *MachineDeploymentStrategy `json:"strategy,omitempty"`

// Minimum number of seconds for which a newly created machine should
// be ready.
// Defaults to 0 (machine will be considered available as soon as it
// is ready)
// MinReadySeconds is the minimum number of seconds for which a Node for a newly created machine should be ready before considering the replica available.
// Defaults to 0 (machine will be considered available as soon as the Node is ready)
// +optional
MinReadySeconds *int32 `json:"minReadySeconds,omitempty"`

Expand Down
4 changes: 2 additions & 2 deletions api/v1beta1/machineset_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ type MachineSetSpec struct {
// +kubebuilder:default=1
Replicas *int32 `json:"replicas,omitempty"`

// MinReadySeconds is the minimum number of seconds for which a newly created machine should be ready.
// Defaults to 0 (machine will be considered available as soon as it is ready)
// MinReadySeconds is the minimum number of seconds for which a Node for a newly created machine should be ready before considering the replica available.
// Defaults to 0 (machine will be considered available as soon as the Node is ready)
// +optional
MinReadySeconds int32 `json:"minReadySeconds,omitempty"`

Expand Down
4 changes: 2 additions & 2 deletions api/v1beta1/zz_generated.openapi.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions config/crd/bases/cluster.x-k8s.io_machinedeployments.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions config/crd/bases/cluster.x-k8s.io_machinesets.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 4d76266

Please sign in to comment.