This repository has been archived by the owner on Aug 22, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 622
[zerotier] New chart for zerotier network #1613
Open
mabels
wants to merge
4
commits into
k8s-at-home:master
Choose a base branch
from
mabels:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
size/L
Categorises a PR that changes 100-499 lines, ignoring generated files.
label
Jun 8, 2022
onedr0p
reviewed
Jun 8, 2022
# -- image tag | ||
# currently there is no zerotier manifest which | ||
# allow to have a arch generic tag | ||
tag: 1.8.10-arm64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tag should probably default to the amd64 variant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not --- changed --- my default is arm64 these days
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mabels You need to use 1.8.10
as tag for the amd64 image.
ghost
added
precommit:ok
CI status: pre-commit validation successful
changelog:ok
CI status: changelog validation successful
and removed
precommit:failed
CI status: pre-commit validation failed
labels
Jun 9, 2022
ghost
added
lint:failed
CI status: linting failed
install:failed
CI status: install failed
labels
Jun 10, 2022
@mabels looks like theres still some linting to fix & the new image tag cant be pulled. |
mabels
requested review from
bjw-s,
billimek,
carpenike and
truxnell
as code owners
July 31, 2022 17:36
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
changelog:ok
CI status: changelog validation successful
install:failed
CI status: install failed
lint:failed
CI status: linting failed
precommit:ok
CI status: pre-commit validation successful
size/L
Categorises a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Added a new Chart to enable ZeroTier Networking
Benefits
You could do in future hopefully
helm install zerotier k8s-at-home/zerotier
Possible drawbacks
I don't know --- keep in mind hostNetwork is default true!
Applicable issues
unknown
no
Checklist
[home-assistant]
)Chart.yaml
according to semver.artifacthub.io/changes
changelog annotation has been updated inChart.yaml
. See Artifact Hub documentation for more info.values.yaml
file.