Init klog in NewNetworkPolicyController #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to propagate the log verbosity level from k3s to kube-router. Signed-off-by: Thomas Ferrandiz <[email protected]>
thomasferrandiz
force-pushed
the
init-logs-netpol
branch
from
0e6ed60 to
1fa6a5e
Compare
|
replaced by k3s-io/k3s#7303 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't run kube-router's main in k3s,
klogis not initalized in kube-router which means that log verbosity is not propagated properly.This PR adds the initialization of klog in the
NewNetworkPolicyControllerfunction so that the flags forklogare recognized when running the netpol controller.We can then set the
VLevelfield in kube-router config in k3s code before starting the netpol controller to set the log verbosity as desired.