Fix rolling compact #365
Merged
Fix rolling compact #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereknola
approved these changes
Nov 11, 2024
This reverts commit aa4f2a7. Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
fix-rolling-compact
branch
from
7b61759
to
3e60a01
Compare
dereknola
approved these changes
Nov 11, 2024
Rather than restarting the outer loop on unhandled error, simmply break out of the inner loop on any error. We always want to update the compact and target rev, and do post-compact operations - so the only thing we really need to check the error for is logging and metrics. Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
fix-rolling-compact
branch
from
3e60a01
to
809103b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #363
Undo the change from #360 and fix things the right way. That worked, but had the unfortunate side effect of moving the compact target forward within the inner loop. This whole thing can be done better by simplifying the error handling.
This reverts commit aa4f2a7.
Rather than restarting the outer loop on unhandled error, simmply break out of the inner loop on any error. We always want to update the compact and target rev, and do post-compact operations - so the only thing we really need to check the error for is logging and metrics.