Add E2E Split Server to Drone, support parallel testing in Drone #9940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]> x Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
brandond
previously approved these changes
Apr 12, 2024
Signed-off-by: Derek Nola <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9940 +/- ##
==========================================
- Coverage 52.73% 43.09% -9.64%
==========================================
Files 157 158 +1
Lines 13826 14017 +191
==========================================
- Hits 7291 6041 -1250
- Misses 5146 6836 +1690
+ Partials 1389 1140 -249
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
approved these changes
Apr 12, 2024
vitorsavian
approved these changes
Apr 12, 2024
dereknola
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Types of Changes
E2E, Drone CI
Verification
Drone still passes
Testing
Its all testing
Linked Issues
#9754
User-Facing Change
Further Comments
After this PR is merged, we should be able to increase the number of parallel runs of
amd64drone instances to 2. We may run into problems around too many parallel docker tests, but we recently migrated alot of that testing into GitHub Actions.