Manually requeue configmap reconcile when no nodes have reconciled snapshots #8683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apshots Silences error message from lasso - this is a normal startup condition when no snapshots exist so we shouldn't log nasty looking errors. Signed-off-by: Brad Davidson <[email protected]>
vitorsavian
approved these changes
Oct 18, 2023
dereknola
approved these changes
Oct 18, 2023
This was referenced Oct 18, 2023
briandowns
approved these changes
Oct 18, 2023
This was referenced Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Manually requeue configmap reconcile when no nodes have reconciled snapshots
Silences error message from lasso - this is a normal startup condition when no snapshots exist so we shouldn't log nasty looking errors.
Types of Changes
bugfix
Verification
See linked issue
Testing
Linked Issues
no nodes have reconciled ETCDSnapshotFile resources, requeuingerror on clusters with no etcd snapshots #8665User-Facing Change
Further Comments