Update kube-router #8423
Merged
Update kube-router #8423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbrtbnfgl
force-pushed
the
kube-router-updater4
branch
from
b616a78 to
d6a6530
Compare
brandond
approved these changes
Sep 25, 2023
|
Could you add something to the the |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8423 +/- ##
==========================================
+ Coverage 44.73% 51.52% +6.78%
==========================================
Files 140 143 +3
Lines 14679 15229 +550
==========================================
+ Hits 6566 7846 +1280
+ Misses 7006 6168 -838
- Partials 1107 1215 +108
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
From the diff I probably did some mistake when I rebased. I'll try to fix it |
|
looks kinda like you merged upstream into your branch, instead of rebasing on top of upstream. |
|
No I rebased them but some conflicted commits were wrongly edited. |
Signed-off-by: Roberto Bonafiglia <[email protected]>
rbrtbnfgl
force-pushed
the
kube-router-updater4
branch
from
d6a6530 to
f86d460
Compare
|
lgtm! |
manuelbuil
approved these changes
Sep 26, 2023
This was referenced Sep 26, 2023
cwayne18
approved these changes
Sep 26, 2023
briandowns
approved these changes
Sep 26, 2023
This was referenced Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Types of Changes
Update Kube-router to fix #8321
Verification
Testing
Linked Issues
#8422
User-Facing Change
Further Comments