Make apiserver egress args conditional on egress-selector-mode #7972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only configure enable-aggregator-routing and egress-selector-config-file if required by egress-selector-mode. Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
fix-aggregator-routing
branch
from
770589c
to
3cd9fe1
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7972 +/- ##
==========================================
+ Coverage 47.69% 51.42% +3.72%
==========================================
Files 143 143
Lines 14564 14566 +2
==========================================
+ Hits 6947 7491 +544
+ Misses 6485 5889 -596
- Partials 1132 1186 +54
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
dereknola
approved these changes
Jul 14, 2023
briandowns
approved these changes
Jul 31, 2023
galal-hussein
approved these changes
Jul 31, 2023
This was referenced Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Make apiserver egress args conditional on egress-selector-mode
Only configure enable-aggregator-routing and egress-selector-config-file if required by egress-selector-mode.
Types of Changes
bugfix
Verification
see linked issue
Testing
Linked Issues
enable-aggregator-routing=truewhenegress-selector-mode=disabled#7971User-Facing Change
Further Comments