Fix error logging in tailscale #7776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7776 +/- ##
===========================================
+ Coverage 19.85% 47.05% +27.20%
===========================================
Files 83 143 +60
Lines 7686 13211 +5525
===========================================
+ Hits 1526 6217 +4691
+ Misses 5930 5899 -31
- Partials 230 1095 +865
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
brandond
requested changes
Jun 14, 2023
pkg/vpn/vpn.go
Outdated
| if err != nil { | ||
| return err | ||
| return errors.New("Error while starting the VPN: " + output) |
There was a problem hiding this comment.
- Errors should not be capitalized
- Maybe wrap the exec error instead of creating a new one?
Suggested change
| return errors.New("Error while starting the VPN: " + output) | |
| return errors.Wrap(err, "tailscale up failed: " + output) |
manuelbuil
force-pushed
the
fixErrorReport
branch
2 times, most recently
from
6057e49 to
632fb37
Compare
johnatasr
approved these changes
Jun 14, 2023
Signed-off-by: Manuel Buil <[email protected]>
manuelbuil
force-pushed
the
fixErrorReport
branch
from
632fb37 to
43611bb
Compare
This was referenced Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Return the output of the command instead of the error. Error will say nothing useful, just "exit 1/2", whereas the output (which is cmd.Stderr) will provide more useful information
Types of Changes
Bugfix
Verification
Start VPN with a wrong joinKey. Now you should see a useful error saying:
Before, you'd only see
exit 1Testing
Linked Issues
#7771
User-Facing Change
Further Comments