E2E: Capture coverage of K3s subcommands #7686
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
RunCmdOnNode
usesudo
. 95% of the commands already using "sudo"GOCOVERDIR
before running thek3s <subcommand>
. This enables coverage capture ofpkg/cli
. So all the calls tok3s secrets-encrypt
ork3s etcd-snapshot
are now captured by the coverage reports.Types of Changes
E2E Testing improvements
Verification
CodeCov went up
Further Comments
Will backport the
sudo
commit, not the coverage changes (older branches don't have go 1.20)