Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Capture coverage of K3s subcommands #7686

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

dereknola
Copy link
Member

Proposed Changes

  • Make all commands called with RunCmdOnNode use sudo. 95% of the commands already using "sudo"
  • If called for, inject GOCOVERDIR before running the k3s <subcommand>. This enables coverage capture of pkg/cli. So all the calls to k3s secrets-encrypt or k3s etcd-snapshot are now captured by the coverage reports.

Types of Changes

E2E Testing improvements

Verification

CodeCov went up

Further Comments

Will backport the sudo commit, not the coverage changes (older branches don't have go 1.20)

@dereknola dereknola requested a review from a team as a code owner June 7, 2023 23:16
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: +4.39 🎉

Comparison is base (e5e1a67) 47.55% compared to head (29edc75) 51.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7686      +/-   ##
==========================================
+ Coverage   47.55%   51.95%   +4.39%     
==========================================
  Files         141      141              
  Lines       14347    14358      +11     
==========================================
+ Hits         6823     7459     +636     
+ Misses       6442     5719     -723     
- Partials     1082     1180      +98     
Flag Coverage Δ
e2etests 49.90% <ø> (?)
inttests 44.83% <ø> (-0.10%) ⬇️
unittests 19.90% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 44 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants