add private registry e2e test #7653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Cardoso <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7653 +/- ##
==========================================
+ Coverage 19.83% 19.85% +0.01%
==========================================
Files 81 81
Lines 7621 7640 +19
==========================================
+ Hits 1512 1517 +5
- Misses 5882 5894 +12
- Partials 227 229 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Ian Cardoso <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
dereknola
requested changes
May 31, 2023
Signed-off-by: Ian Cardoso <[email protected]>
osodracnai
force-pushed
the
private-registry-e2e
branch
from
49b1da3 to
479c18c
Compare
dereknola
approved these changes
Jun 1, 2023
brandond
approved these changes
Jun 8, 2023
osodracnai
added a commit
to osodracnai/k3s
that referenced
this pull request
Jun 9, 2023
add private registry e2e test Signed-off-by: Ian Cardoso <[email protected]> Co-authored-by: Derek Nola <[email protected]>
osodracnai
added a commit
to osodracnai/k3s
that referenced
this pull request
Jun 9, 2023
add private registry e2e test Signed-off-by: Ian Cardoso <[email protected]> Co-authored-by: Derek Nola <[email protected]>
dereknola
added a commit
that referenced
this pull request
Jun 9, 2023
* add private registry e2e test (#7653) add private registry e2e test Signed-off-by: Ian Cardoso <[email protected]> Co-authored-by: Derek Nola <[email protected]> * E2E: Startup test cleanup + RunCommand Enhancement (#7388) * Add beforesuite to startup * Reduce timeouts for startup * Fix cleanup + set kubeconfig Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Ian Cardoso <[email protected]> Signed-off-by: Derek Nola <[email protected]> Co-authored-by: Derek Nola <[email protected]>
dereknola
added a commit
that referenced
this pull request
Jun 9, 2023
* add private registry e2e test (#7653) add private registry e2e test Signed-off-by: Ian Cardoso <[email protected]> Co-authored-by: Derek Nola <[email protected]> * E2E: Startup test cleanup + RunCommand Enhancement (#7388) * Add beforesuite to startup * Reduce timeouts for startup * Fix cleanup + set kubeconfig Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Ian Cardoso <[email protected]> Signed-off-by: Derek Nola <[email protected]> Co-authored-by: Derek Nola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add a test using private registries
Types of Changes
Verification
go test -timeout=15m ./tests/e2e/privateregistry/... -run E2ETesting
Linked Issues
#6062
User-Facing Change
Further Comments