Make LB image configurable when compiling k3s #7626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangedeng
force-pushed
the
make-lb-image-configurable
branch
from
f9f4ff4 to
31b50ea
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7626 +/- ##
===========================================
+ Coverage 19.85% 47.65% +27.79%
===========================================
Files 81 140 +59
Lines 7640 14323 +6683
===========================================
+ Hits 1517 6825 +5308
- Misses 5894 6419 +525
- Partials 229 1079 +850
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
It is no way we can configure the lb image because it is a const value. It would be better that we make it variable value and we can override the value like the `helm-controller` job image when compiling k3s/rke2 Signed-off-by: Yuxing Deng <[email protected]>
orangedeng
force-pushed
the
make-lb-image-configurable
branch
from
31b50ea to
d589088
Compare
brandond
approved these changes
May 31, 2023
|
I'm ok with this, I just wanted to make sure we engage the right folks to understand the product changes driving it. |
manuelbuil
approved these changes
May 31, 2023
This was referenced Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is no way we can configure the lb image because it is a const value. It would be better that we make it variable value and we can override the value like the
helm-controllerjob image when compiling k3s/rke2Proposed Changes
Make
DefaultLBImageas a variable value instead of const value.Types of Changes
New Feature
Verification
N/A
Testing
Basically there is nothing changed after the PR merge as the variable name is not changed but I think we should test the service LB function in k3s cluster after merge.
Linked Issues
Issue: #7625
User-Facing Change
No
Further Comments
No