Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.26] Pin emicklei/go-restful to v3.9.0 #7598

Conversation

brandond
Copy link
Member

@brandond brandond commented May 24, 2023

Proposed Changes

Fix regression in legacy API prefix, until upstream pulls in support for MergePathStrategy from emicklei/go-restful#523

Types of Changes

bugfix

Verification

See linked issue

Testing

kubectl get --raw /api/

Linked Issues

User-Facing Change

NONE

Further Comments

Fix regression in legacy API prefix, until upstream pulls in support for MergePathStrategy from emicklei/go-restful#523

Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond requested a review from a team as a code owner May 24, 2023 00:06
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6cd5403) 10.09% compared to head (ec58625) 10.09%.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.26    #7598   +/-   ##
=============================================
  Coverage         10.09%   10.09%           
=============================================
  Files               148      148           
  Lines             10728    10728           
=============================================
  Hits               1083     1083           
  Misses             9422     9422           
  Partials            223      223           
Flag Coverage Δ
unittests 10.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@brandond brandond merged commit 7cefebe into k3s-io:release-1.26 May 24, 2023
@brandond brandond deleted the fix-legacy-api-trailing-slash-release-1.26 branch June 6, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants