Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin emicklei/go-restful to v3.9.0 #7597

Merged
merged 1 commit into from
May 24, 2023

Conversation

brandond
Copy link
Member

@brandond brandond commented May 24, 2023

Proposed Changes

Fix regression in legacy API prefix, until upstream pulls in support for MergePathStrategy from emicklei/go-restful#523

Types of Changes

bugfix

Verification

See linked issue

Testing

kubectl get --raw /api/

Linked Issues

User-Facing Change

NONE

Further Comments

@brandond brandond requested a review from a team as a code owner May 24, 2023 00:00
Fix regression in legacy API prefix, until upstream pulls in support for MergePathStrategy from emicklei/go-restful#523

Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond force-pushed the fix-legacy-api-trailing-slash branch from 9776fd7 to 8f55b17 Compare May 24, 2023 00:01
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (91c5e0d) 47.51% compared to head (8f55b17) 47.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7597      +/-   ##
==========================================
+ Coverage   47.51%   47.54%   +0.02%     
==========================================
  Files         140      140              
  Lines       14284    14284              
==========================================
+ Hits         6787     6791       +4     
+ Misses       6415     6413       -2     
+ Partials     1082     1080       -2     
Flag Coverage Δ
inttests 44.89% <ø> (+0.02%) ⬆️
unittests 19.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants