Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add '-all' flag to apply to inactive systemd units #7567

Merged
merged 1 commit into from
May 17, 2023

Conversation

manuelbuil
Copy link
Contributor

Proposed Changes

The wildcard k3s* only applies to loaded and active systemd units. However, in tests such as multicidr or the upcoming tailscale, the k3s-agent unit is loaded but inactive. Therefore, the wildcard will not apply and thus the e2e test fails

Types of Changes

Bugfix

Verification

Test multicidr

Testing

Linked Issues

#7566

User-Facing Change


Further Comments

@manuelbuil manuelbuil requested a review from a team as a code owner May 17, 2023 10:29
@manuelbuil manuelbuil requested a review from est-suse May 17, 2023 10:29
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -27.77 ⚠️

Comparison is base (2b24c99) 47.60% compared to head (290f67c) 19.83%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7567       +/-   ##
===========================================
- Coverage   47.60%   19.83%   -27.77%     
===========================================
  Files         140       81       -59     
  Lines       14284     7621     -6663     
===========================================
- Hits         6800     1512     -5288     
+ Misses       6410     5882      -528     
+ Partials     1074      227      -847     
Flag Coverage Δ
inttests ?
unittests 19.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 115 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants