Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate netutil methods into /util/net.go #7422

Merged
merged 1 commit into from
May 5, 2023

Conversation

manuelbuil
Copy link
Contributor

Proposed Changes

Moving two functions from one file to another

Types of Changes

Code clean up

Verification

Just do regular k3s verifications

Testing

Just do regular k3s verifications

Linked Issues

#7421

User-Facing Change


Further Comments

@manuelbuil manuelbuil requested a review from a team as a code owner May 4, 2023 14:53
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.13 ⚠️

Comparison is base (e1d4cff) 19.57% compared to head (437ad12) 19.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7422      +/-   ##
==========================================
- Coverage   19.57%   19.45%   -0.13%     
==========================================
  Files          81       81              
  Lines        5461     5495      +34     
==========================================
  Hits         1069     1069              
- Misses       4170     4204      +34     
  Partials      222      222              
Flag Coverage Δ
unittests 19.45% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/net.go 5.80% <0.00%> (-1.64%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants