Fail to validate server tokens that use bootstrap id/secret format #7389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereknola
reviewed
May 1, 2023
brandond
force-pushed
the
fix-server-token-format-validation
branch
from
f3b12e9 to
9465243
Compare
dereknola
approved these changes
May 1, 2023
Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
fix-server-token-format-validation
branch
from
9465243 to
4a618fb
Compare
briandowns
approved these changes
May 4, 2023
|
merging; test flake has been resolved on mater |
This was referenced May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fail to validate server tokens that use bootstrap id/secret format
Exit out with a proper
failed to normalize server token; must be in format K10<CA-HASH>::<USERNAME>:<PASSWORD> or <PASSWORD>error instead of failing later on when the bootstrap save code notices that the password is an empty string.Types of Changes
bugfix
Verification
Start a k3s server with a --token value that uses the bootstrap token format.
Testing
Yes
Linked Issues
User-Facing Change
Further Comments