Fix issues with --disable-agent and --egress-selector-mode=pod|cluster
#7331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #7331 +/- ##
==========================================
+ Coverage 9.82% 19.34% +9.52%
==========================================
Files 147 81 -66
Lines 10845 5449 -5396
==========================================
- Hits 1065 1054 -11
+ Misses 9558 4173 -5385
Partials 222 222
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 66 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
brandond
force-pushed
the
no-agentless-tunnel-auth
branch
from
76af32c to
80d68b4
Compare
brandond
changed the title
--disable-agent and --egress-selector-mode=pod|cluster
Don't set up the agent tunnel authorizer on agentless servers, and warn when agentless servers won't have a way to reach in-cluster endpoints. Signed-off-by: Brad Davidson <[email protected]>
dereknola
requested changes
Apr 21, 2023
brandond
force-pushed
the
no-agentless-tunnel-auth
branch
from
80d68b4 to
e23431b
Compare
dereknola
approved these changes
Apr 24, 2023
dereknola
reviewed
Apr 24, 2023
Signed-off-by: Brad Davidson <[email protected]>
Several places in the code used a 5-second retry loop to wait on Runtime.Core to be set. This caused a race condition where OnChange handlers could be added after the Wrangler shared informers were already started. When this happened, the handlers were never called because the shared informers they relied upon were not started. Fix that by requiring anything that waits on Runtime.Core to run from a cluster controller startup hook that is guaranteed to be called before the shared informers are started, instead of just firing it off in a goroutine that retries until it is set. Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
no-agentless-tunnel-auth
branch
from
e23431b to
57b517f
Compare
briandowns
approved these changes
Apr 28, 2023
dereknola
approved these changes
Apr 28, 2023
This was referenced May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Improve egress selector handling on agentless servers
Types of Changes
bugfix
Verification
See linked issues
Testing
Yes, added one
Linked Issues
--disable-agentstill attempt to run agent tunnel authorizer #7329--egress-selector-mode=cluster|podare broken #7332User-Facing Change
Further Comments