Enable FindString to search dotD config files #7323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <[email protected]>
brandond
requested changes
Apr 19, 2023
Signed-off-by: Derek Nola <[email protected]>
brandond
requested changes
Apr 19, 2023
Signed-off-by: Derek Nola <[email protected]>
brandond
reviewed
Apr 20, 2023
Signed-off-by: Derek Nola <[email protected]>
brandond
approved these changes
Apr 20, 2023
Signed-off-by: Derek Nola <[email protected]>
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #7323 +/- ##
==========================================
+ Coverage 19.30% 19.42% +0.11%
==========================================
Files 81 81
Lines 5459 5472 +13
==========================================
+ Hits 1054 1063 +9
- Misses 4183 4185 +2
- Partials 222 224 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
briandowns
approved these changes
May 2, 2023
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
May 2, 2023
* Enable FindString to search dotD config files * Address multiple arg cases Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
May 2, 2023
* Enable FindString to search dotD config files * Address multiple arg cases Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
May 2, 2023
* Enable FindString to search dotD config files * Address multiple arg cases Signed-off-by: Derek Nola <[email protected]>
This was referenced May 2, 2023
dereknola
added a commit
that referenced
this pull request
May 2, 2023
* Handle multiple arguments with StringSlice flags (#7380) * Add helper function for multiple arguments in stringslice Signed-off-by: Derek Nola <[email protected]> * Cleanup server setup with util function Signed-off-by: Derek Nola <[email protected]> * Enable FindString to search dotD config files (#7323) * Enable FindString to search dotD config files * Address multiple arg cases Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
that referenced
this pull request
May 2, 2023
* Handle multiple arguments with StringSlice flags (#7380) * Add helper function for multiple arguments in stringslice * Cleanup server setup with util function Signed-off-by: Derek Nola <[email protected]> * Enable FindString to search dotD config files (#7323) * Enable FindString to search dotD config files * Address multiple arg cases Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
that referenced
this pull request
May 2, 2023
* Handle multiple arguments with StringSlice flags (#7380) * Cleanup server setup with util function Signed-off-by: Derek Nola <[email protected]> * Enable FindString to search dotD config files (#7323) * Address multiple arg cases Signed-off-by: Derek Nola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
FindStringnow correctly searches for a CLI argument inside of theconfig.yaml.dfolderTypes of Changes
CLI Bug Fix
Verification
Create a config folder setup:
/etc/rancher/k3s/config.yamland/etc/rancher/k3s/config.yaml.d/test.yamltest.yamlfill withprefer-bundled-bin: trueTesting
New Unit test clause
Linked Issues
#7316
User-Facing Change
Further Comments