Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kube-router ACCEPT rule insertion and install script to clean rules before start #7274

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

rbrtbnfgl
Copy link
Contributor

@rbrtbnfgl rbrtbnfgl commented Apr 12, 2023

Proposed Changes

Updated Kube-router version to add the default ACCEPT iptables rules right after the latest kubernetes rules to fix setup where a firewall that adds DROP rules is enabled.
Updated install.sh script to clean the iptables rules before K3s start.

Types of Changes

Verification

Testing

Linked Issues

#7203 #7244 #7251

User-Facing Change

The embedded kube-router controller has been updated to fix a regression that caused traffic from pods to be blocked by any default drop/deny rules present on the host. Users should still confirm that any externally-managed firewall rules explicitly allow traffic to/from pod and service networks, but this returns the old behavior that was relied upon by some users.

Further Comments

@rbrtbnfgl rbrtbnfgl requested a review from a team as a code owner April 12, 2023 09:25
@rbrtbnfgl rbrtbnfgl changed the title Kube router iptables Update Kube-router ACCEPT rule insertion and install script to clean rules before start Apr 12, 2023
@rbrtbnfgl rbrtbnfgl force-pushed the kube-router-iptables branch 2 times, most recently from 294e0c3 to 356290f Compare April 12, 2023 13:51
@rbrtbnfgl
Copy link
Contributor Author

It seems that opensuse-leap test doesn't like iptables on the install script.
Does it right to keep the command there or not?

@brandond
Copy link
Member

brandond commented Apr 12, 2023

I was a little concerned about that. I see that we already use them in the uninstall script, but expecting them to be present at install time is probably not reasonable. Maybe just add a check to see if iptables and ip6tables exist before calling them?

@rbrtbnfgl rbrtbnfgl force-pushed the kube-router-iptables branch from 356290f to d8a23e4 Compare April 12, 2023 16:33
@rbrtbnfgl
Copy link
Contributor Author

Can I merge it even if it fails during s390 build?

@brandond
Copy link
Member

I would say yes, go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants