Fix issue with stale connections to removed LB server #7194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
force-pushed
the
close-lb-backend-removed
branch
9 times, most recently
from
55b2cc2 to
210f5b8
Compare
brandond
commented
Apr 1, 2023
| cancel() | ||
| delete(disconnect, address) | ||
| logrus.Infof("Stopped tunnel to %s", address) | ||
| validEndpoint := map[string]bool{} |
There was a problem hiding this comment.
this all diffs very poorly, but it's just been indented inside the go func(){ goroutine
dereknola
reviewed
Apr 3, 2023
Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
close-lb-backend-removed
branch
3 times, most recently
from
24fdc8b to
4e85024
Compare
brandond
force-pushed
the
close-lb-backend-removed
branch
3 times, most recently
from
eb6289f to
9899eea
Compare
briandowns
approved these changes
Apr 3, 2023
Track LB connections through each server so that they can be closed when it is removed. Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
close-lb-backend-removed
branch
from
9899eea to
3da3db3
Compare
galal-hussein
approved these changes
Apr 4, 2023
dereknola
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Types of Changes
bugfix
Verification
--debugkubectl delete node)Testing
Linked Issues
User-Facing Change
Further Comments