[UpdateCLI] Improve Klipper Helm and Helm controller bumps #7146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guilherme Macedo <[email protected]>
|
CC @matttrach and @brandond |
matttrach
reviewed
Mar 24, 2023
brandond
approved these changes
Mar 31, 2023
matttrach
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Improve how UpdateCLI handles the bump of Klipper Helm and Helm Controller, since Helm Controller Go dependency in
go.modcan only be bumped if it's using the right Klipper Helm version. If it's, then we also bump Klipper Helm version inscripts/airgap/image-list.txt.Due to that, we decoupled the Klipper LB update, because it's not related to Klipper Helm.
This addresses this issue - #7024 (review).
Types of Changes
Verification
An example PR is available in https://github.com/macedogm/k3s/pull/5.
Testing
Linked Issues
User-Facing Change
N/A
Further Comments