Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ServiceLB dual-stack ingress IP listing #6979

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

brandond
Copy link
Member

@brandond brandond commented Feb 17, 2023

Proposed Changes

Fix ServiceLB dual-stack ingress IP listing

Types of Changes

bugfix

Verification

See linked issue

Testing

added a unit test for this function

Linked Issues

User-Facing Change

Resolved an issue with ServiceLB that would cause it to advertise node IPv6 addresses, even if the cluster or service was not enabled for dual-stack operation.

Further Comments

@brandond brandond requested a review from a team as a code owner February 17, 2023 01:00
@codecov-commenter
Copy link

Codecov Report

Base: 9.51% // Head: 9.65% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (ba0702d) compared to base (2156015).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #6979      +/-   ##
=========================================
+ Coverage    9.51%   9.65%   +0.13%     
=========================================
  Files         146     146              
  Lines       10757   10738      -19     
=========================================
+ Hits         1024    1037      +13     
+ Misses       9515    9483      -32     
  Partials      218     218              
Flag Coverage Δ
unittests 9.65% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cloudprovider/servicelb.go 3.56% <100.00%> (+3.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond force-pushed the fix_servicelb_ipfamily branch from ba0702d to 107fec7 Compare February 17, 2023 22:42
@brandond brandond merged commit cbe4bcf into k3s-io:master Feb 21, 2023
@brandond brandond deleted the fix_servicelb_ipfamily branch June 6, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants