-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coreos and sle micro to selinux support #6945
Add coreos and sle micro to selinux support #6945
Conversation
LGTM syntactically! |
install.sh
Outdated
@@ -470,16 +470,29 @@ setup_selinux() { | |||
rpm_target=sle | |||
rpm_site_infix=microos | |||
package_installer=zypper | |||
if [ "${ID_LIKE:-}" == suse ] && [ "${VARIANT_ID:-}" == sle-micro ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: do we need to check for suse
again when we're already in a suse-specific block?
Posting here just for tracking until other issues get created. Single node install is good - SLES 15SP4 |
Current issues noticed in testing:Fedora:
SLE Micro:
|
Validated On:
Scenarios:
Cluster config:
Commits:
|
Signed-off-by: galal-hussein <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
bfb19ba
to
62eab2c
Compare
This change is not working for flatcar container linux |
On flatcar the k3s.service is not created anymore. |
Signed-off-by: galal-hussein [email protected]
Proposed Changes
Types of Changes
new feature
Verification
Testing
1- install k3s with selinux enabled on EL7
2- install k3s with selinux enabled on EL8
3- install k3s with selinux enabled on coreos fedora (experimental)
4- install k3s with selinux enabled on microos and SLE
5- install k3s with selinux enabled on SLE micro
We need to make sure that k3s-selinux is updated correctly on all systems with existing installations
Linked Issues
User-Facing Change
Further Comments