Ensure flag type consistency #6852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
approved these changes
Jan 30, 2023
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
dereknola
force-pushed
the
flag_consistent
branch
from
4faf3d2 to
de420b7
Compare
briandowns
approved these changes
Jan 31, 2023
This was referenced Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
&cli.BoolFlagand string flags as&cli.StringFlag, now all flags maintain the same declaration structure.Types of Changes
Code Consistency
Verification
N/A K3s builds
Testing
K3s builds
Linked Issues
#2308
User-Facing Change
Further Comments
I chose to go with "all pointers" because if we ever upgrade to urfave cli v2, flags are required to be pointers.