E2E: Consoldiate docker and prefer bundled tests into new startup test #6851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
ShylajaDevadiga
approved these changes
Feb 1, 2023
brandond
approved these changes
Feb 1, 2023
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Feb 6, 2023
k3s-io#6851) * Convert docker E2E to startup E2E * Move preferedbundled into the e2e startup test Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Feb 6, 2023
k3s-io#6851) * Convert docker E2E to startup E2E * Move preferedbundled into the e2e startup test Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Feb 6, 2023
k3s-io#6851) * Convert docker E2E to startup E2E * Move preferedbundled into the e2e startup test Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
that referenced
this pull request
Feb 6, 2023
* Consolidate E2E tests and GH Actions (#6772) * Consolidate cluster reset and snapshot E2E tests * Add more context to secrets-encryption test * Reuse build workflow * Convert updatecli to job level permissions * Remove dweomer microos from E2E and install testing Signed-off-by: Derek Nola <[email protected]> * E2E: Consoldiate docker and prefer bundled tests into new startup test (#6851) * Convert docker E2E to startup E2E * Move preferedbundled into the e2e startup test Signed-off-by: Derek Nola <[email protected]> * Update nightly channel Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
that referenced
this pull request
Feb 6, 2023
* Consolidate E2E tests and GH Actions (#6772) * Consolidate cluster reset and snapshot E2E tests * Add more context to secrets-encryption test * Reuse build workflow * Convert updatecli to job level permissions * Remove dweomer microos from E2E and install testing Signed-off-by: Derek Nola <[email protected]> * E2E: Consoldiate docker and prefer bundled tests into new startup test (#6851) * Convert docker E2E to startup E2E * Move preferedbundled into the e2e startup test Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
that referenced
this pull request
Feb 7, 2023
* Consolidate E2E tests and GH Actions (#6772) * Consolidate cluster reset and snapshot E2E tests * Add more context to secrets-encryption test * Reuse build workflow * Convert updatecli to job level permissions * Remove dweomer microos from E2E and install testing Signed-off-by: Derek Nola <[email protected]> * E2E: Consoldiate docker and prefer bundled tests into new startup test (#6851) * Convert docker E2E to startup E2E * Move preferedbundled into the e2e startup test Signed-off-by: Derek Nola <[email protected]> --------- Signed-off-by: Derek Nola <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
dockerandpreferbundledE2E tests into a singlestartupE2E test. This test is unique among the E2E tests in that the arguments used to launch K3s are dynamic throughout the test.Types of Changes
E2E test improvements
Verification
E2E startup test passes
Linked Issues
N/A
User-Facing Change
Further Comments
This test should not be expanded unless you want to test a very specific thing: a new flag that changes how K3s operates on launch, that applies to both Server and Agent nodes, where you don't have anything to test beyond "do k3s default pods start".
If you just want to test a server flag, use the startup integration test, its faster and easier to run.