Allow ServiceLB to honor ExternalTrafficPolicy=Local
#6726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
force-pushed
the
servicelb_externaltrafficpolicy
branch
4 times, most recently
from
23a802e to
50e4142
Compare
brandond
changed the title
ExternalTrafficPolicy=LocalExternalTrafficPolicy=Local
brandond
force-pushed
the
servicelb_externaltrafficpolicy
branch
from
50e4142 to
cc544c0
Compare
briandowns
reviewed
Jan 26, 2023
galal-hussein
approved these changes
Jan 26, 2023
briandowns
approved these changes
Jan 26, 2023
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
servicelb_externaltrafficpolicy
branch
from
cc544c0 to
bb3208b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Allow ServiceLB to honor
ExternalTrafficPolicy. Previously, ServiceLB violated the LoadBalancer spec by not properly delivering traffic only to the node-local endpoints of the service when theExternalTrafficPolicywas set toLocal. It would instead advertise the addresses of all nodes eligible to run ServiceLB, and forwarded traffic to all cluster endpoints.Ref: https://kubernetes.io/docs/reference/kubernetes-api/service-resources/service-v1/#:~:text=externaltrafficpolicy%20(string)
Types of Changes
bugfix; enhancement
Verification
Testing
Linked Issues
User-Facing Change
Further Comments