Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cronjob example #6707

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Fix cronjob example #6707

merged 1 commit into from
Jan 30, 2023

Conversation

aelek73
Copy link
Contributor

@aelek73 aelek73 commented Jan 7, 2023

In the case of "* */5 * * *", it runs every minute past every 5 hours, so it is not true that it runs every 5 hours.
To solve it set 0 as minutes (0 */5 * * *)
Related PR:
rancher/rke2-docs#38

Proposed Changes

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

@aelek73 aelek73 requested a review from a team as a code owner January 7, 2023 20:35
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Don't forget to sign your commits for DCO.

Copy link
Member

@cwayne18 cwayne18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you! We're currently in a code freeze due to releases, but will merge this as soon as we can!

@cwayne18
Copy link
Member

cwayne18 commented Jan 9, 2023

Oops I'm sorry @akose73 , as @brandond pointed out please re-commit with -s to make sure the DCO check can pass. Thanks again!

Related PR:
rancher/rke2-docs#38

Signed-off-by: Akos Elek <[email protected]>
@aelek73
Copy link
Contributor Author

aelek73 commented Jan 9, 2023

Ohh, so sorry. I signed-off my commit and pushed again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants