-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated ioutil package #6230
Conversation
Signed-off-by: Derek Nola <[email protected]>
Codecov ReportBase: 9.74% // Head: 9.76% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #6230 +/- ##
=========================================
+ Coverage 9.74% 9.76% +0.01%
=========================================
Files 139 139
Lines 10120 10130 +10
=========================================
+ Hits 986 989 +3
- Misses 8932 8937 +5
- Partials 202 204 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Derek Nola <[email protected]>
4fbef71
to
fe50281
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Derek Nola <[email protected]>
fe50281
to
f0caf90
Compare
Signed-off-by: Derek Nola [email protected]
Proposed Changes
ioutil
package was deprecated in go 1.16 and even more in 1.17. This PR replaces all deprecated functions from ioutil with their replacements. Most are a drop in name change, butioutil.ReadDir -> os.ReadDir
required a bit more change.Types of Changes
Deprecation package replacement.
Verification
make
passesTesting
N/A
Linked Issues
#6231
User-Facing Change
Further Comments