Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 1.24] Add flannel-external-ip when there is a k3s node-external-ip #6189

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

manuelbuil
Copy link
Contributor

Backport: #6180
Issue: #6188

@manuelbuil manuelbuil requested a review from a team as a code owner September 29, 2022 08:05
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2022

Codecov Report

Base: 9.72% // Head: 9.71% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (0be4ef9) compared to base (a8e0c66).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.24   #6189      +/-   ##
===============================================
- Coverage          9.72%   9.71%   -0.01%     
===============================================
  Files               138     138              
  Lines             10060   10064       +4     
===============================================
  Hits                978     978              
- Misses             8883    8887       +4     
  Partials            199     199              
Flag Coverage Δ
unittests 9.71% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/flannel/flannel.go 0.00% <0.00%> (ø)
pkg/agent/run.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@manuelbuil manuelbuil merged commit 205ccc7 into k3s-io:release-1.24 Sep 29, 2022
@manuelbuil manuelbuil deleted the flannel-external-ip1.24 branch September 29, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants