Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.21] Increase agent's apiserver ready timeout #4457

Merged

Conversation

brandond
Copy link
Member

@brandond brandond commented Nov 11, 2021

Proposed Changes

Since we now start the server's agent sooner and in the background, we
may need to wait longer than 30 seconds for the apiserver to become
ready on downstream projects such as RKE2.

Since this essentially just serves as an analogue for the server's
apiReady channel, there's little danger in setting it to something
relatively high.

Types of Changes

bugfix

Verification

  • Normal CI checks on K3s.
  • Should resolve CI failures currently seen when updating K3s in RKE2.

Linked Issues

User-Facing Change


Further Comments

@brandond brandond requested a review from a team as a code owner November 11, 2021 01:29
Copy link
Contributor

@dweomer dweomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we now start the server's agent sooner and in the background, we
may need to wait longer than 30 seconds for the apiserver to become
ready on downstream projects such as RKE2.

Since this essentially just serves as an analogue for the server's
apiReady channel, there's little danger in setting it to something
relatively high.

Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond force-pushed the fix_apiserver_ready_release-1.21 branch from 0f39a89 to 3ce0801 Compare November 11, 2021 09:51
@dweomer dweomer merged commit 10c854c into k3s-io:release-1.21 Nov 11, 2021
@brandond brandond deleted the fix_apiserver_ready_release-1.21 branch June 6, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants