Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add binary size check script, makefile target, and added to CI #2209

Merged
merged 3 commits into from
Sep 4, 2020
Merged

add binary size check script, makefile target, and added to CI #2209

merged 3 commits into from
Sep 4, 2020

Conversation

briandowns
Copy link
Contributor

@briandowns briandowns commented Sep 4, 2020 •
edited
Loading

Proposed changes

Add script to check binary size and include in ci.

Types of changes

Verification

Linked Issues

#2205

Further comments

@briandowns briandowns requested a review from a team as a code owner September 4, 2020 17:23
@briandowns briandowns self-assigned this Sep 4, 2020
dweomer
dweomer suggested changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@dweomer dweomer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI build is failing. Please run the check immediately after invoking the package script in the ci script (allowing you to drop the drone file changes)

@briandowns
Copy link
Contributor Author

Thanks. I think that's a lot cleaner.

@briandowns briandowns changed the title add binary size check script, makefile target, and added to drone add binary size check script, makefile target, and added to CI Sep 4, 2020
@briandowns briandowns requested review from dweomer and a team September 4, 2020 18:28
@dweomer dweomer merged commit f72d39a into k3s-io:master Sep 4, 2020
briandowns added a commit to briandowns/k3s that referenced this pull request Jan 14, 2021
@briandowns
add binary size check script, makefile target, and added to CI (k3s-i…
e6ec11e 
…o#2209)

* add binary size check script, makefile target, and added to drone

Signed-off-by: Brian Downs <[email protected]>

* move script call to package script

Signed-off-by: Brian Downs <[email protected]>

* move script call to ci script

Signed-off-by: Brian Downs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dweomer dweomer dweomer approved these changes

Assignees

@briandowns briandowns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@briandowns @dweomer @davidnuzik