add setup hook capabilities for rke2 #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Downs <[email protected]>
briandowns
force-pushed
the
add_hook_for_rke2
branch
from
2d1d7b5 to
a4b2953
Compare
dweomer
approved these changes
Aug 19, 2020
brandond
reviewed
Aug 19, 2020
There was a problem hiding this comment.
Might these better be called StartupHooks? They're called in StartServer, after the apiserver and controllers are started, well after any other setup has already been done.
Based on the current name I was expecting to be able to do some setup, maybe alter the configuration if I needed to customize something before it was used to set up the rest of the system.
|
They'd be used during RKE2 setup. I open to calling them anything that makes their use clear. |
|
So k3s calls these hooks during startup, but rke2 calls them during setup? Or does rke2 add them during setup? I'm in favor of naming them after the place they get called. |
Signed-off-by: Brian Downs <[email protected]>
|
changed |
cjellick
reviewed
Aug 19, 2020
Signed-off-by: Brian Downs <[email protected]>
cjellick
approved these changes
Aug 20, 2020
brandond
approved these changes
Aug 20, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds the ability to add hooks to be run in bootstrapping in k3s that will ultimately be used during rke2 startup.
Types of changes
Adds a slice to a struct field and referenced during k3s start up.
Verification
Verification will be had through it's use in this RKE2 pull request. rancher/rke2#199
Linked Issues
N/A
Further comments
N/A