Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: golang 1.14 on alpine 3.12 #1893

Closed
wants to merge 1 commit into from
Closed

build: golang 1.14 on alpine 3.12 #1893

wants to merge 1 commit into from

Conversation

dweomer
Copy link
Contributor

@dweomer dweomer commented Jun 12, 2020 •
edited
Loading

  • golang 1.14.4
  • go mod tidy
  • golangci-lint 1.27.0 (better output, doesn't crash with go 1.14)
  • add zlib-static as build-time dependency

@dweomer dweomer mentioned this pull request Jun 12, 2020
Closed
AkihiroSuda
AkihiroSuda suggested changes Jun 13, 2020
View reviewed changes
Copy link
Contributor

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

containerd and Kube do not support Go 1.14 due to the EINTR changes and bbolt issue. I suggest skipping 1.14.

@brandond
Copy link
Member

brandond commented Jun 13, 2020 •
edited
Loading

Good overview with references: go-gitea/gitea#11620 (comment)

What a pain in the ass.

@cjellick
Copy link
Contributor

Thansk for the heads up @AkihiroSuda

@dweomer
Copy link
Contributor Author

dweomer commented Jun 17, 2020

I had forgotten why I was avoiding go 1.14 https://golang.org/doc/go1.14#runtime. Thanks for reminding me @AkihiroSuda

@dweomer dweomer closed this Jun 17, 2020
@warmchang
Copy link
Contributor

warmchang commented Jun 18, 2020 •
edited
Loading

The k/k upstream is dealing with this problem:
[WIP] Update Golang to v1.14.4 kubernetes/kubernetes#88638

Should be go1.15:
https://groups.google.com/g/kubernetes-dev/c/uN-hX5zUMFA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda requested changes

@ibuildthecloud ibuildthecloud Awaiting requested review from ibuildthecloud

@erikwilson erikwilson Awaiting requested review from erikwilson

@galal-hussein galal-hussein Awaiting requested review from galal-hussein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dweomer @brandond @cjellick @warmchang @AkihiroSuda