[release-1.28] Add tolerations support for DaemonSet pods #10705
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This pull request introduces a new feature that allows ServiceLB to handle Kubernetes tolerations defined in a service's annotations. The changes include:
getTolerations
method, which retrieves and validates tolerations from a service's annotations in JSON or YAML string format.newDaemonSet
method to append the retrieved tolerations to the DaemonSet's pod tolerations.These changes enable users to customize tolerations directly through service annotations, providing greater flexibility in pod scheduling.
Types of Changes
Verification
To verify the changes:
LoadBalancer
type andsvccontroller.k3s.cattle.io/tolerations
annotation containing valid JSON or YAML formatted tolerations list.yaml example:
json example:
Testing
Linked Issues
User-Facing Change
Further Comments