Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance E2E Hardened option #10558

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Enhance E2E Hardened option #10558

merged 2 commits into from
Jul 25, 2024

Conversation

dereknola
Copy link
Member

Proposed Changes

  • Remove unnecessary config.yaml options
  • Add required tls-cipher-suites argument to config.yaml
  • Rework default of E2E_HARDENED to accept true (psa)
  • Auto install kube-bench for easier CIS validation

Types of Changes

Testing Enhancements

Verification

Manually run multiple times when overhauling the K3s CIS profiles

Testing

N/A this is just for manual QA

Linked Issues

N/A

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner July 24, 2024 16:28
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.49%. Comparing base (58ab259) to head (77c0364).
Report is 8 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (58ab259) and HEAD (77c0364). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (58ab259) HEAD (77c0364)
e2etests 7 6
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10558      +/-   ##
==========================================
- Coverage   49.47%   43.49%   -5.98%     
==========================================
  Files         179      179              
  Lines       14924    14936      +12     
==========================================
- Hits         7384     6497     -887     
- Misses       6161     7241    +1080     
+ Partials     1379     1198     -181     
Flag Coverage Δ
e2etests 36.31% <ø> (-10.02%) ⬇️
inttests 36.68% <ø> (+16.96%) ⬆️
unittests 13.35% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit ecff337 into k3s-io:master Jul 25, 2024
29 checks passed
@dereknola dereknola deleted the hardened_slim branch July 29, 2024 16:53
dereknola added a commit to dereknola/k3s that referenced this pull request Aug 5, 2024
* Remove unnecessary hardened arguments

Signed-off-by: Derek Nola <[email protected]>

* slim down hardened arguments

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit to dereknola/k3s that referenced this pull request Aug 5, 2024
* Remove unnecessary hardened arguments

Signed-off-by: Derek Nola <[email protected]>

* slim down hardened arguments

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit to dereknola/k3s that referenced this pull request Aug 5, 2024
* Remove unnecessary hardened arguments

Signed-off-by: Derek Nola <[email protected]>

* slim down hardened arguments

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit to dereknola/k3s that referenced this pull request Aug 5, 2024
* Remove unnecessary hardened arguments

Signed-off-by: Derek Nola <[email protected]>

* slim down hardened arguments

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit to dereknola/k3s that referenced this pull request Aug 5, 2024
* Remove unnecessary hardened arguments

Signed-off-by: Derek Nola <[email protected]>

* slim down hardened arguments

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit to dereknola/k3s that referenced this pull request Aug 5, 2024
* Remove unnecessary hardened arguments

Signed-off-by: Derek Nola <[email protected]>

* slim down hardened arguments

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit to dereknola/k3s that referenced this pull request Aug 5, 2024
* Remove unnecessary hardened arguments

Signed-off-by: Derek Nola <[email protected]>

* slim down hardened arguments

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit to dereknola/k3s that referenced this pull request Aug 5, 2024
* Remove unnecessary hardened arguments

Signed-off-by: Derek Nola <[email protected]>

* slim down hardened arguments

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit that referenced this pull request Aug 6, 2024
* Remove unnecessary hardened arguments

Signed-off-by: Derek Nola <[email protected]>

* slim down hardened arguments

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit that referenced this pull request Aug 6, 2024
* Remove unnecessary hardened arguments

Signed-off-by: Derek Nola <[email protected]>

* slim down hardened arguments

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit that referenced this pull request Aug 6, 2024
* Remove unnecessary hardened arguments

Signed-off-by: Derek Nola <[email protected]>

* slim down hardened arguments

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit that referenced this pull request Aug 6, 2024
* Remove unnecessary hardened arguments

Signed-off-by: Derek Nola <[email protected]>

* slim down hardened arguments

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
ludost pushed a commit to asimovo-platform/k3s that referenced this pull request Oct 2, 2024
* Remove unnecessary hardened arguments

Signed-off-by: Derek Nola <[email protected]>

* slim down hardened arguments

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants