Don't use server value from config file for etcd-snapshot commands #10514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10514 +/- ##
==========================================
- Coverage 49.47% 43.52% -5.96%
==========================================
Files 179 179
Lines 14924 14924
==========================================
- Hits 7384 6496 -888
- Misses 6161 7223 +1062
+ Partials 1379 1205 -174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
force-pushed
the
fix-etcd-snapshot-server-flag
branch
from
1441f76
to
0b9ca0b
Compare
…commands Fixes an issue where running etcd-snapshot commands on a node that has a server address set in the config will manage snapshots on that server, instead of on the local node as intended. Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
fix-etcd-snapshot-server-flag
branch
from
0b9ca0b
to
ef2b70d
Compare
This was referenced Jul 15, 2024
vitorsavian
approved these changes
Jul 15, 2024
briandowns
approved these changes
Jul 15, 2024
cwayne18
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Don't use server and token values from config file for etcd-snapshot commands
Fixes an issue where running etcd-snapshot commands on a node that has a server address set in the config will manage snapshots on that server, instead of on the local node as intended.
Types of Changes
bugfix
Verification
See linked issue
Testing
Linked Issues
k3s etcd-snapshotcommands run against server specified in config file, instead of local server #10513User-Facing Change
Further Comments