Skip to content

Commit

Permalink
add format command on Makefile and remove vendor
Browse files Browse the repository at this point in the history
This commit adds the format command to make it easier to be compliant to golangci-lint issues

Signed-off-by: Ian Cardoso <[email protected]>
  • Loading branch information
osodracnai committed May 31, 2023
1 parent eb83af0 commit abde5fe
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 1 deletion.
15 changes: 15 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,18 @@ Signed-off-by: Jane Smith <[email protected]>

In most cases, you can add this signoff to your commit automatically with the
`-s` flag to `git commit`. Please use your real name and a reachable email address.


## Golangci-lint ##

There is a CI check for formatting on our code, you'll need to install `goimports` to be able to attend this check, you can do it by running the command:

```
go install golang.org/x/tools/cmd/goimports@latest
```

then run:

```
make format
```
7 changes: 6 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
TARGETS := $(shell ls scripts | grep -v \\.sh)
GO_FILES ?= $$(find . -name '*.go' | grep -v generated)


.dapper:
@echo Downloading dapper
Expand All @@ -12,7 +14,6 @@ $(TARGETS): .dapper

.PHONY: deps
deps:
go mod vendor
go mod tidy

release:
Expand All @@ -32,3 +33,7 @@ binary-size-check:
.PHONY: image-scan
image-scan:
scripts/image_scan.sh $(IMAGE)

format:
gofmt -s -l -w $(GO_FILES)
goimports -w $(GO_FILES)

0 comments on commit abde5fe

Please sign in to comment.