Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConfChangeAddLearnerNode to the list of config changes #1

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

galal-hussein
Copy link

@galal-hussein galal-hussein commented Sep 11, 2020

To fix a panic that happens when force-new-cluster flag is passed to
etcd node if the cluster had learner nodes added from before

Fixes etcd-io#12285

Copy link

@briandowns briandowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again for the walk through on the issue and resolution.

Copy link

@cjellick cjellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I rubber stamping this without really understanding what's going on? YOU BET!

@galal-hussein galal-hussein merged commit 158b371 into k3s-io:release-3.4 Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants