Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] createClusterForm: show registry status #6

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

iwilltry42
Copy link
Member

Helps you to not connect to an exited registry.

vscode-k3d_0

Copy link
Collaborator

@inercia inercia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iwilltry42 it looks good to me, thanks! it just needs a rebase (some minor changes in some imports).

@iwilltry42
Copy link
Member Author

iwilltry42 commented Jan 18, 2021

@iwilltry42 it looks good to me, thanks! it just needs a rebase (some minor changes in some imports).

No clue, what the hell happened here O.o

EDIT: pushed a fixed branch 👍

@iwilltry42 iwilltry42 force-pushed the feature/registry-status branch from 4384ed0 to a78a0c4 Compare January 18, 2021 07:31
Helps you to not connect to an exited registry
@iwilltry42 iwilltry42 force-pushed the feature/registry-status branch from a78a0c4 to 7ec1106 Compare January 18, 2021 07:35
Copy link
Collaborator

@inercia inercia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@inercia inercia merged commit f785dfd into k3d-io:main Jan 18, 2021
@iwilltry42 iwilltry42 deleted the feature/registry-status branch January 18, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants