Improved handling of the registry URL

Signed-off-by: Alvaro Saurin <[email protected]>

package.json

@@ -242,7 +242,6 @@
                 "category": "Kubernetes: k3d",
                 "title": "Delete a Server node"
             }
-
         ],
         "keybindings": [
             {
@@ -325,6 +324,7 @@
         "@types/request-promise-native": "^1.0.17",
         "@types/shelljs": "^0.8.3",
         "@types/tmp": "0.0.33",
+        "@types/url-join": "^4.0.0",
         "@types/vscode": "^1.44.0",
         "ts-loader": "^6.0.4",
         "tslint": "^5.8.0",
@@ -346,6 +346,7 @@
         "shelljs": "^0.8.3",
         "spawn-rx": "^3.0.0",
         "tmp": "^0.0.33",
+        "url-join": "^4.0.1",
         "vscode-azureextensionui": "^0.38.2",
         "vscode-kubernetes-tools-api": "^1.0.0"
     },
@@ -356,4 +357,4 @@
     "bugs": {
         "url": "https://github.com/inercia/vscode-k3d/issues"
     }
-}
+}

src/utils/registry.ts

@@ -1,10 +1,11 @@
 import { workspace } from "vscode";
 import { Response } from "request";
 import * as request from 'request-promise-native';
-import { URL } from "url";
 
 import { Errorable } from '../utils/errorable';
 
+const urljoin = require('url-join');
+
 // maximum number of tags to return
 const MAX_TAGS_RESULTS = 12;
 
@@ -54,9 +55,13 @@ function ITagCompare(a: ITag, b: ITag): number {
 export async function registryTagsForImage(registry: string, namespace: string, repoName: string,
     regex?: RegExp, arch?: string, limit: number = MAX_TAGS_RESULTS): Promise<Errorable<ITag[]>> {
 
+    if (!registry.startsWith("http")) {
+        registry = `https://${registry}`;
+    }
+
     let res: ITag[] = [];
-    const urlInit = new URL(`${registry}/v2/repositories/${namespace}/${repoName}/tags`);
-    let url: string = urlInit.toString();
+
+    let url: string = urljoin(registry, "v2", "repositories", namespace, repoName, "tags").toString();
     while (true) {
         let response = await registryRequest<ITags>('GET', url.toString());
         // TODO: we should check the response errors