install.sh: Invoke curl with secure defaults #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When invoking the install script, the installation process can fail silently so that the `k3d` binary includes only the ASCII string 'Not found'. This can be avoided by passing the `--fail` flag so that the command fails if a 4XX or 5XX response is received. This change adds a `scurl` function that invokes `curl` with this flag, as well as flags that ensure that at least TLS v1.2 is used (this helps mitigate protocol downgrade attacks). This is based on the defaults we use in Linkerd. See: https://github.com/linkerd/linkerd2/blob/a0b112471eef7e3975fbc8564df52d83894c3fa3/bin/scurl Signed-off-by: Oliver Gould <[email protected]>
In my case, I was calling the script when the |
iwilltry42
approved these changes
Mar 15, 2022
|
Good catch @olix0r ! Thanks for providing this addition :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invoking the install script, the installation process can fail
silently so that the
k3dbinary includes only the ASCII string 'Notfound'. This can be avoided by passing the
--failflag so that thecommand fails if a 4XX or 5XX response is received.
This change adds a
scurlfunction that invokescurlwith this flag,as well as flags that ensure that at least TLS v1.2 is used (this helps
mitigate protocol downgrade attacks).
This is based on the defaults we use in Linkerd. See: https://github.com/linkerd/linkerd2/blob/a0b112471eef7e3975fbc8564df52d83894c3fa3/bin/scurl