Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/action/arch: Switch from absolute Arch docker version to a more relaxed one #966

Merged
merged 2 commits into from
Feb 17, 2022

Conversation

JohnnyCrazy
Copy link
Contributor

@JohnnyCrazy JohnnyCrazy commented Feb 10, 2022

What

Relaxing the Arch Linux docker version in the deploy script. In the end we're not depending on specific packages of Arch Linux since we install most of them ourselves. This should prevent builds breaking like it currently does, because of outdated keys or similar.

The alternative would be to use sth like pacman-key --refresh-keys, but this takes always takes a while...

EDIT: I pushed another commit which will update archlinux-keyring when the deploy starts, which automatically gets all the latest keys.

Why

Breaking deploy scripts to AUR

Implications

@iwilltry42 iwilltry42 self-requested a review February 17, 2022 19:45
@iwilltry42 iwilltry42 added the enhancement New feature or request label Feb 17, 2022
@iwilltry42 iwilltry42 added this to the v5.4.0 milestone Feb 17, 2022
@iwilltry42 iwilltry42 force-pushed the update-aur-docker-release branch from c7c33a9 to dba38fa Compare February 17, 2022 19:45
Copy link
Member

@iwilltry42 iwilltry42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you very much :)

@iwilltry42 iwilltry42 changed the title Switch from absolute Arch docker version to a more relaxed one ci/action/arch: Switch from absolute Arch docker version to a more relaxed one Feb 17, 2022
@iwilltry42 iwilltry42 merged commit 9e506b2 into k3d-io:main Feb 17, 2022
@JohnnyCrazy JohnnyCrazy deleted the update-aur-docker-release branch February 17, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants