New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] only replace default api host with docker host #879

Merged

iwilltry42 merged 1 commit into main from fix/kubeconfig-server

Dec 7, 2021

Member

iwilltry42 commented Dec 7, 2021 •

edited

Loading

fixes #876

Changes

move docker-machine lookup into general GetHost function
only use GetHost result if API host is default (0.0.0.0) to not override user-provided value
when looking up IP for host value (e.g. localhost), only use IPv4 to prevent errors

iwilltry42 added bug priority/high labels

iwilltry42 added this to the v5.2.1 milestone

iwilltry42 self-assigned this

iwilltry42 force-pushed the fix/kubeconfig-server branch from 03b423c to 82bb912 Compare

December 7, 2021 07:17


          only replace default api host with docker host

669246b

iwilltry42 force-pushed the fix/kubeconfig-server branch from 82bb912 to 669246b Compare

December 7, 2021 07:23

iwilltry42 marked this pull request as ready for review

December 7, 2021 07:24

iwilltry42 merged commit 25ec400 into main

iwilltry42 deleted the fix/kubeconfig-server branch

December 7, 2021 15:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug priority/high