[Enhancement] Improved Podman compatibility #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This call seems to be unnecessary and removing it allows usage with Podman. See https://github.com/docker/cli/blob/b0343d9104a1794c3252fa45b985710d6b6afc05/cli/command/container/exec.go#L111
This might be useful when a user wants to use a different network to run the registry, especially for Podman users. This patch avoids adding such a flag to clusterCreate to avoid polluting the arguments for that command. A better long-term solution would be to create a new network for the registry.
serverwentdown
force-pushed
the
fix-podman-compat
branch
from
b8a2233 to
8738657
Compare
iwilltry42
requested changes
Dec 4, 2021
- network is not ambiguous for registry, so it can just be network instead of DefaultNetwork - DefaultNetwork as a type however could be ambiguous in that it could be confused for k3d's default network (i.e. `k3d cluster create` without a name would create the "default" `k3d-k3s-default` network)
iwilltry42
reviewed
Dec 4, 2021
iwilltry42
changed the title
|
Oh, I never actually wrote a comment 😁 |
|
I just gave it a try:
This is great! 😃 |
|
@all-contributors please add @serverwentdown for code |
|
I've put up a pull request to add @serverwentdown! 🎉 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ContainerExecStart--default-networkoption toregistry createfor Podman users & special casesWhy
k3dwith Podman (See [FEATURE] Podman support #84)Implications
None
Docs
I'm working on docs, but they can only be merged when containers/podman#12328 is released.
@all-contributors please add @serverwentdown for code