[FIX]: import all requested images (#701, @mszostok) #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszostok
force-pushed
the
fix-load-images
branch
from
ed9df26 to
c631a15
Compare
|
Now that was a nasty bug.. thanks for fixing this @mszostok ! :) |
iwilltry42
changed the title
rancherio-gh-m
pushed a commit
that referenced
this pull request
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Unfortunately, the PR #653 broke the
k3d image importcommand. Since then, you can import only the first found image due tobreakinstead ofcontinuestatement inforloop.This PR fixes that bug and adds test coverage to avoid regression in the future.
Why
Fix #700
Implications
None