[Feature] auto mode and zsh support for shell command #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the enhancement. It looks good in general. I am not a zsh user, but from what I read, it seems zsh uses the "PROMPT" variable, instead of PS1. Is this true? If yes, then should also improve this for zsh users? |
|
Actually both |
|
Nice! Should line 87 be touched up further? |
|
Whoops... sure thing, updated 👍 |
zeerorg
reviewed
May 31, 2019
zeerorg
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the
shellcommand now usesauto-mode, where it selects the shell based on the$SHELLenvironment variable. It then checks if that shell is supported and selects the required options from a map.I also added support (options) for
zsh.