[Feature] Implement --auto-restart flag for the create command #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwilltry42
approved these changes
May 21, 2019
|
Personally, I am not a big fan of aliasing. It is confusing to the user and hard to document. Let's pick one name and stick with it. How about --unless-stopped? not a great name, but to the point. BTW, I like auto-restart, It would be my 2nd choice. |
True, same here 👍
I fear that |
When creating clusters with the --auto-restart flag, any running cluster will remain "running" up on docker daemon restart. By default, without this flag, a "running" cluster becomes "stopped" after docker daemon restart. Clusters stopped with 'k3d stop' command will remain stopped after docker daemon restart regardless the settings of this flag.
|
Let's go with --auto-restart. Updated. |
andyz-dev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #15.
When creating clusters with the --always-on flag, the cluster can
remain in the "running" state across the docker daemon restart.
Without this flag, a "running" cluster becomes "stopped" after docker
daemon restart.
Clusters stopped with 'k3d stop' command will remain stopped after
docker daemon restart.